Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Java LoggerFromOptions Logger implementation #13003

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

New Java LoggerFromOptions Logger implementation #13003

wants to merge 4 commits into from
+223 −1

Commits on Nov 19, 2024

  1. New Java LoggerFromOptions Logger implementation 

    The LoggerFromOptions class is a Logger implementation which allows the placement of the logger outside the DB. Used as a logger for a ReadOnly DB on a readonly filesystem, for instance.

This is the Java manifestation of CreateLoggerFromOptions - created from a DBOptions.
    @alanpaxton
    alanpaxton committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    54be502 View commit details
    Browse the repository at this point in the history

  2. Make the API more readable 

    - Use a static method CreateLoggerFromOptions to wrap the now private LoggerFromOptionsconstructor
- Class comment
- change names of internal methods for readability
    @alanpaxton
    alanpaxton committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8bd8269 View commit details
    Browse the repository at this point in the history

  3. Review comments for Java LoggerFromOptions 

    Use standard macro for returning C++ pointer as Java
JNIEXPORT and JNICALL not necessary in the implementation part of JNI methods, just the (autogenerated) declarations
    @alanpaxton
    alanpaxton committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e720927 View commit details
    Browse the repository at this point in the history

  4. Trim log file options sizes in test

    @alanpaxton
    alanpaxton committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e3e4609 View commit details
    Browse the repository at this point in the history