Refactor RandomCoin trait #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irakliyk
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Look good! Thank you! I left a few comments inline. Most of them are pretty small. The only more significant one is about using nonce from an instance variable rather than passing it via parameters. But if this significantly complicates FRI verifier interface, we can keep it as is.
|
The clippy error seems similar to the one we hit on plonky2. Setting manually |
irakliyk
approved these changes
Sep 20, 2023
Thank you! This seems to have fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #206