Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StarkProof::new_dummy() #232

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Implement StarkProof::new_dummy() #232

merged 2 commits into from
Nov 30, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Nov 30, 2023

It is currently impossible to create a dummy StarkProof object for use in tests of crates of depend on winterfell. This PR solves this problem by exposing a function new_dummy().

irakliyk
irakliyk approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a couple of tiny nits inline.

air/src/proof/mod.rs Outdated Show resolved Hide resolved
fri/src/proof.rs Outdated Show resolved Hide resolved
@plafer plafer mentioned this pull request Nov 30, 2023
Merged
3 tasks
@irakliyk irakliyk merged commit 73d0b7e into facebook:main Nov 30, 2023
9 checks passed
@plafer plafer mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irakliyk irakliyk irakliyk approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plafer @irakliyk @facebook-github-bot