Add MoQSession::drain API #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds support to MoQFramer, MoQCodec and MoQSession to send and receive fetch streams Differential Revision: D65532676
Summary: This will close the session when all fetches and subscribes are complete. This required changing the objects() and payload() read loops a bit. Since the sources are shared pointers, the callees can continue reading from them after the session is gone. We use try_dequeue() to drain the queue after the session's token has been cancelled. Reviewed By: NEUDitao Differential Revision: D65532678
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65532678 |
afrind
added a commit
to afrind/moxygen
that referenced
this pull request
Nov 14, 2024
Summary: This will close the session when all fetches and subscribes are complete. This required changing the objects() and payload() read loops a bit. Since the sources are shared pointers, the callees can continue reading from them after the session is gone. We use try_dequeue() to drain the queue after the session's token has been cancelled. Reviewed By: NEUDitao Differential Revision: D65532678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This will close the session when all fetches and subscribes are complete. This required changing the objects() and payload() read loops a bit. Since the sources are shared pointers, the callees can continue reading from them after the session is gone. We use try_dequeue() to drain the queue after the session's token has been cancelled.
Reviewed By: NEUDitao
Differential Revision: D65532678