Add reload-to-profile for Fusebox #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdmondChuiHW
force-pushed
the
reload2profile
branch
from
0bab29e
to
545b1d5
Compare
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 6, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under new architecture. Bridging for legacy Android and iOS will be added in follow-up diffs Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 7, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 7, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 8, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 8, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 8, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 8, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 8, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 8, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 8, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 8, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 9, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 9, 2024
…6856) Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 9, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 10, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 10, 2024
Summary: Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 10, 2024
Summary: Pull Request resolved: #46856 Changelog: [General][Added] - Add support for reload-to-profile in Fusebox. (Part 1 of 2: native) CDT: facebookexperimental/rn-chrome-devtools-frontend#117 React: facebook/react#31021 This diff adds support for reload2profile under bridge and bridgeless for iOS, Android, and C++ Reviewed By: hoxyq Differential Revision: D63233256 fbshipit-source-id: f2f2814491e785b03af143cc26639ef178881fff
hoxyq
reviewed
Oct 16, 2024
Comment on lines
174
to
178
| this.#wall.listen((message: ReactDevToolsTypes.Message): void => { | ||
| if (message.event === 'reloadAppForProfiling') { | ||
| SDK.ResourceTreeModel.ResourceTreeModel.reloadAllPages(false); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Use bridge for it, not wall. Ideally, we should be using Store, because this should be the only public API entrypoint.
But please use bridge, just to make sure we use same thing as what extension is using, in case we are going to change this.
EdmondChuiHW
force-pushed
the
reload2profile
branch
2 times, most recently
from
ca07da2
to
87f66ee
Compare
EdmondChuiHW
force-pushed
the
reload2profile
branch
from
87f66ee
to
14660ef
Compare
2 tasks
EdmondChuiHW
commented
Oct 16, 2024
Comment on lines
+18
to
+20
| addListener(event: string, listener: (params: unknown) => any): void; | ||
| removeListener(event: string, listener: Function): void; | ||
| shutdown: () => void; |
There was a problem hiding this comment.
Will make it official in facebook/react#31274
Comment on lines
+83
to
+86
| override dispose(): void { | ||
| this.#bridge?.removeListener('reloadAppForProfiling', this.#handleReloadAppForProfiling); | ||
| } | ||
|
|
There was a problem hiding this comment.
We have some existing listeners that needs to be unsubscribed here too. Following up in #129
hoxyq
approved these changes
Oct 16, 2024
EdmondChuiHW
added a commit
to facebook/react
that referenced
this pull request
Oct 16, 2024
New types used by Fusebox facebookexperimental/rn-chrome-devtools-frontend#117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dependant on Flow types from facebook/react#31021
Updated the TS def in this PR to allow building without errors. Will do a proper upgrade after everything has landed
Test plan
Test E2E in D63233256
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.