Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Fusebox setClientMetadata handshake with ReactNativeApplicationModel #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huntie
Copy link

@huntie huntie commented Nov 26, 2024

Summary

Depends on facebook/react-native#47962.

In an aim to simplify the rn_fusebox.ts entry point, drops our use of FuseboxClient.setClientMetadata as a RNDT-client-identifying handshake, in favour ReactNativeApplication.enable.

  • Replace FuseboxClientMetadataModel with existing ReactNativeApplicationModel
    • Now auto-inits, registration call is moved to rn_fusebox.ts (IMO, correctness fix that now includes this model only for this entrypoint).
    • Migrate rnPerfMetrics calls over (unchanged).
  • Remove CDP definitions for FuseboxClient domain.

Test plan

[Incoming]

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants