Replace Fusebox setClientMetadata handshake with ReactNativeApplicationModel #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on facebook/react-native#47962.
In an aim to simplify the
rn_fusebox.ts
entry point, drops our use ofFuseboxClient.setClientMetadata
as a RNDT-client-identifying handshake, in favourReactNativeApplication.enable
.FuseboxClientMetadataModel
with existingReactNativeApplicationModel
rn_fusebox.ts
(IMO, correctness fix that now includes this model only for this entrypoint).rnPerfMetrics
calls over (unchanged).FuseboxClient
domain.Test plan
[Incoming]
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.