[RFC] Implement gloo abort for graceful shutdown #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. Are you able to add a test for this change? |
|
Ignore the CI breakage for now. I'm trying to revive the CI for this repository. |
Sure, I will add a test and resolve the merge conflicts soon. |
c-p-i-o
approved these changes
Nov 5, 2024
|
Hey @c-p-i-o how does the PR look to you? Do you think it is ready to merge? Please let me know if you have any comments. |
c-p-i-o
approved these changes
Nov 26, 2024
|
@c-p-i-o has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @c-p-i-o can you please let me know what tests are failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pytorch/pytorch#130345 it was requested to implement a
ProcessGroupGloo.shutdown()for faster recovery from distributed rank failures. This PR is a first step into accomplishing the proper shutdown. The second step would be implementinggloo::abort()within the PyTorch'sProcessGroupGloo.