Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

colors for show_interior_samples.py #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jstraub
Copy link
Contributor

@jstraub jstraub commented Sep 11, 2019

coloring for positive and negative samples

Interior Samples | -home-jstraub-data-deepSDF-replica-data-SdfSamples-replica-room_0-mesh npz_235

Interior Samples | -home-jstraub-data-deepSDF-replica-data-SdfSamples-replica-room_0-mesh npz_236

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 11, 2019
@tschmidt23
Copy link

Super cool! So I guess green is near the surface, blue outside and red inside?

Two quick thoughts:

  • This no longer shows the internal samples so should perhaps be accompanied by a name change?
  • This is definitely useful but I think the old implementation which shows only interior samples is also useful for different reasons. Do you think we should make this more flexible with a command line argument or button on a panel? Another useful feature might be to generalize the old "show everything with SDF val <= 0" rule to a flexible level set band where you can set the minimum and maximum SDF values to display, which would allow inspection of density at different distance from the surface.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants