Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README and fix issue in one-to-many matches #121

Closed
wants to merge 1 commit into from
Closed

Update README and fix issue in one-to-many matches #121

wants to merge 1 commit into from

Conversation

jimouris
Copy link
Collaborator

@jimouris jimouris commented Dec 19, 2023 •
edited by shubho
Loading

Types of changes

Fixed small issue in one-to-many matching and update README.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

Addressed some PETS reviews.

How Has This Been Tested (if it applies)

Tests pass.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@jimouris jimouris added bug Something isn't working documentation Improvements or additions to documentation labels Dec 19, 2023
@jimouris jimouris requested a review from shubho December 19, 2023 00:50
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2023
@facebook-github-bot
Copy link
Contributor

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@prasadbuddhavarapu merged this pull request in fe511dc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubho shubho shubho approved these changes

Assignees

@shubho shubho

@jimouris jimouris

Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimouris @facebook-github-bot @shubho