Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle --exclude-testsuite and --test-suffix options #273

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

raffaelecarelle
Copy link
Contributor

Fixes #199

Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Can you add a changelog entry?

tests/Functional/Filter/ExcludeTest.php Outdated Show resolved Hide resolved
@raffaelecarelle raffaelecarelle force-pushed the #199-handle-exclude-testsuite branch 3 times, most recently from 39c1d76 to bd0f957 Compare September 24, 2024 11:14
@raffaelecarelle
Copy link
Contributor Author

Thank you for your contribution! Can you add a changelog entry?

Done.

@raffaelecarelle raffaelecarelle changed the title Add exclude-testsuite option to support test suite exclusion Handle --exclude-testsuite and --test-suffix options Sep 24, 2024
@raffaelecarelle
Copy link
Contributor Author

Added --test-suffix option also

@Jean85

@raffaelecarelle raffaelecarelle force-pushed the #199-handle-exclude-testsuite branch 2 times, most recently from 1c0edf0 to ccf0ebc Compare September 24, 2024 12:00
@raffaelecarelle
Copy link
Contributor Author

Rebased and squashed

src/Filter/Filter.php Outdated Show resolved Hide resolved
tests/Functional/Filter/ExcludeTest.php Show resolved Hide resolved
tests/Functional/Filter/SuffixFilterTest.php Show resolved Hide resolved
Extended SuffixFilterTest with additional checks for filtering test files by suffix. Included both single suffix and comma-separated suffix scenarios to ensure proper functionality.
Separated logic for converting suffixes to an array and filtering files into distinct private methods. This improves code readability and maintainability by encapsulating specific functionalities. The refactor facilitates extension and testing of individual components.
Updated `ExcludeTest` to handle comma-separated test suite names in exclude options. Refactored `Filter` class to streamline processing of comma-separated values through a new helper method `getTrimmedArray()`.
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Jean85 Jean85 merged commit 2ff9a07 into facile-it:2.x Sep 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle --exclude-testsuite and --test-suffix options
2 participants