Merge pull request #97 from factly/fix/logout

add credentials required in logout request
factly · Nov 23, 2021 · 764edef · 764edef
2 parents 9fab178 + eb4524c
commit 764edef
Showing 1 changed file with 22 additions and 19 deletions.
diff --git a/web/src/components/GlobalNav/AccountMenu.js b/web/src/components/GlobalNav/AccountMenu.js
@@ -23,25 +23,28 @@ const AccountMenu = () => {
   React.useEffect(() => {
     dispatch(getUserProfile());
   }, [dispatch]);
-
-  const handleLogout = ()=>{
-    fetch(window.REACT_APP_KRATOS_PUBLIC_URL + '/self-service/logout/browser')
-    .then((res) => {
-      if (res.status === 200) {
-        return res.json();
-      } else {
-        throw new Error(res.status);
-      }
+
+  const handleLogout = () => {
+    fetch(window.REACT_APP_KRATOS_PUBLIC_URL + '/self-service/logout/browser', {
+      credentials: 'include',
     })
-    .then((res)=>{
-      window.location.href = res.logout_url
-    }).catch((err)=>{
+      .then((res) => {
+        if (res.status === 200) {
+          return res.json();
+        } else {
+          throw new Error(res.status);
+        }
+      })
+      .then((res) => {
+        window.location.href = res.logout_url;
+      })
+      .catch((err) => {
         notification.error({
-          message:'Error',
-          description:'Unable to login'
-        })
-    })
-  }
+          message: 'Error',
+          description: 'Unable to logout',
+        });
+      });
+  };
   return (
     <Menu mode="horizontal">
       <Menu.SubMenu
@@ -67,8 +70,8 @@ const AccountMenu = () => {
           </Link>
         </Menu.Item>
         <Menu.Item key="logout" onClick={handleLogout}>
-            <LogoutOutlined />
-            Logout
+          <LogoutOutlined />
+          Logout
         </Menu.Item>
       </Menu.SubMenu>
     </Menu>