Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming RDF export #102

Merged
merged 4 commits into from
Dec 23, 2014
Merged

Streaming RDF export #102

merged 4 commits into from
Dec 23, 2014

Conversation

armisael
Copy link
Contributor

@armisael armisael commented Nov 5, 2014

With these changes the RDF export becomes streaming:

  • the data is not handled twice;
  • the triples are not loaded in memory as a whole, but row by row;
  • the output generation starts while reading the rows.

Fixes issue #101

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import com.google.refine.browsing.Engine;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving these imports when they're unchanged adds noise to the diff

@armisael
Copy link
Contributor Author

armisael commented Nov 6, 2014

My IDE messed up imports and indentation, I'll try to:

  • amend imports and indentation (I fear it will be painful)
  • deprecate the buildModel method
  • throw RuntimeExceptions instead of just logging

Thanks

fadmaa added a commit that referenced this pull request Dec 23, 2014
@fadmaa fadmaa merged commit 3925b93 into fadmaa:master Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants