fix(misc): do not print formatting errors while setting up nx cloud i…

…n nx init (nrwl#21302)
fahslaj · Jan 24, 2024 · 70fd808 · 70fd808
1 parent d9c53e1
commit 70fd808
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 4 deletions.
diff --git a/docs/generated/packages/nx/generators/connect-to-nx-cloud.json b/docs/generated/packages/nx/generators/connect-to-nx-cloud.json
@@ -18,6 +18,11 @@
         "type": "string",
         "description": "Name of Nx Cloud installation invoker (ex. user, add-nx-to-monorepo, create-nx-workspace, nx-upgrade",
         "default": "user"
+      },
+      "hideFormatLogs": {
+        "type": "boolean",
+        "description": "Hide formatting logs",
+        "x-priority": "internal"
       }
     },
     "additionalProperties": false,

diff --git a/packages/nx/src/command-line/init/init-v2.ts b/packages/nx/src/command-line/init/init-v2.ts
@@ -97,7 +97,7 @@ export async function initHandler(options: InitArgs): Promise<void> {
   if (useNxCloud) {
     output.log({ title: '🛠️ Setting up Nx Cloud' });
     execSync(
-      `${pmc.exec} nx g nx:connect-to-nx-cloud --installationSource=nx-init-pcv3 --quiet --no-interactive`,
+      `${pmc.exec} nx g nx:connect-to-nx-cloud --installationSource=nx-init-pcv3 --quiet --hideFormatLogs --no-interactive`,
       {
         stdio: [0, 1, 2],
         cwd: repoRoot,

diff --git a/packages/nx/src/generators/internal-utils/format-changed-files-with-prettier-if-available.ts b/packages/nx/src/generators/internal-utils/format-changed-files-with-prettier-if-available.ts
@@ -7,7 +7,10 @@ import type * as Prettier from 'prettier';
  * @param tree - the file system tree
  */
 export async function formatChangedFilesWithPrettierIfAvailable(
-  tree: Tree
+  tree: Tree,
+  options?: {
+    silent?: boolean;
+  }
 ): Promise<void> {
   let prettier: typeof Prettier;
   try {
@@ -51,7 +54,9 @@ export async function formatChangedFilesWithPrettierIfAvailable(
             | string)
         );
       } catch (e) {
-        console.warn(`Could not format ${file.path}. Error: "${e.message}"`);
+        if (!options?.silent) {
+          console.warn(`Could not format ${file.path}. Error: "${e.message}"`);
+        }
       }
     })
   );

diff --git a/packages/nx/src/nx-cloud/generators/connect-to-nx-cloud/connect-to-nx-cloud.ts b/packages/nx/src/nx-cloud/generators/connect-to-nx-cloud/connect-to-nx-cloud.ts
@@ -95,6 +95,7 @@ function printSuccessMessage(url: string) {
 interface ConnectToNxCloudOptions {
   analytics: boolean;
   installationSource: string;
+  hideFormatLogs?: boolean;
 }
 
 function addNxCloudOptionsToNxJson(
@@ -135,7 +136,9 @@ export async function connectToNxCloud(
 
     addNxCloudOptionsToNxJson(tree, nxJson, r.token);
 
-    await formatChangedFilesWithPrettierIfAvailable(tree);
+    await formatChangedFilesWithPrettierIfAvailable(tree, {
+      silent: schema.hideFormatLogs,
+    });
 
     return () => printSuccessMessage(r.url);
   }

diff --git a/packages/nx/src/nx-cloud/generators/connect-to-nx-cloud/schema.json b/packages/nx/src/nx-cloud/generators/connect-to-nx-cloud/schema.json
@@ -15,6 +15,11 @@
       "type": "string",
       "description": "Name of Nx Cloud installation invoker (ex. user, add-nx-to-monorepo, create-nx-workspace, nx-upgrade",
       "default": "user"
+    },
+    "hideFormatLogs": {
+      "type": "boolean",
+      "description": "Hide formatting logs",
+      "x-priority": "internal"
     }
   },
   "additionalProperties": false,