fix: node 20 support #141
Merged
fix: node 20 support #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
nice, thanks @TheBojda! please update package-lock.json too and LGTM |
|
I think, I added it. |
Merged
|
Unfortunately test are failing: https://github.com/fairDataSociety/fdp-play/actions/runs/9503353206/job/26193586676 |
nugaon
added a commit
that referenced
this pull request
Jun 13, 2024
Merged
|
Release v3.1.0 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've upgraded node-fetch and modified utils/wait.ts to be sure it uses the node-fetch version of fetch.
shim/crypto.ts is also modified. I'm not sure the fix is correct, but the bee node looks working. I bought a batch, uploaded data, and got it successfully, so the base functionality is working.