Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(music.band): removes leading whitespace #3015

Conversation

JeremasPosta
Copy link
Contributor

@JeremasPosta JeremasPosta commented Oct 16, 2024

Motivation / Background

  • There was an example with a leading whitespace: ' The'
  • Replacing it with The Killers

Additional information

CLOSES #3011

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

- There was an example with a leading whitespace: ' The'
- Replacing it with 'The Killers'
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! do you mind ordering the bands alphabetically? it would make it easier to spot repeated bands 👀

@JeremasPosta
Copy link
Contributor Author

@stefannibrasil , here you have!

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 :shipit:

@stefannibrasil stefannibrasil merged commit 6795451 into faker-ruby:main Oct 18, 2024
7 checks passed
@JeremasPosta JeremasPosta deleted the fix/remove_example_with_leading_whitespace branch October 18, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Undesired?) leading whitespace in music.band
2 participants