Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to specify a list of alertmanager servers + fix attribute name ... #1051

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Issif
Copy link
Member

@Issif Issif commented Nov 18, 2024

…for cloud events

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

  • Allow to set a list of AlertManager servers to where the payload must be sent, it's required when HA mode is enabled in AlertManager.
  • remove the disallowed character used in the CloudEvent extension

Which issue(s) this PR fixes:

#1025
#1050

Fixes #

Special notes for your reviewer:

@Issif Issif added this to the 2.30 milestone Nov 18, 2024
leogr
leogr previously approved these changes Nov 19, 2024
@poiana
Copy link

poiana commented Nov 19, 2024

LGTM label has been added.

Git tree hash: c714e21c0be5020f907d14aa100c387c69891896

@poiana poiana added the lgtm label Nov 21, 2024
@poiana
Copy link

poiana commented Nov 21, 2024

LGTM label has been added.

Git tree hash: c3692b5dff83d8c813f5dfcc05c83d01903fa07c

@poiana
Copy link

poiana commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 0f4f794 into master Nov 21, 2024
6 checks passed
@poiana poiana deleted the fix/alertmanager-ha branch November 21, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants