Refactor text #42
Merged
Refactor text #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactoring has the following targets: - Remove duplication between "Paragraph" and "Text", keep "Paragraph" structure only - Rename "Paragraph" structure to more clear "Text" - Treat "Text" as a flow element, introduce "TextBlock" after layouting which is a content element - Remove duplication in measuring and allocation With this refactoring, the following features were prepared - Introduce alignment of text (center, right, justified) - Introduce structure tagging of text
Refactor towards defining line height in the layout only Fix text measurer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.