Reformulate dependencies #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version seems to stun the concretizer (see #96)
|
Nice, thank you! We should make the same MR in upstream space to fix the Octopus package on Can you do that, @iamashwin99 ? |
1 similar comment
|
Nice, thank you! We should make the same MR in upstream space to fix the Octopus package on Can you do that, @iamashwin99 ? |
iamashwin99
reviewed
Oct 24, 2023
| @@ -108,7 +109,8 @@ class Octopus(AutotoolsPackage, CudaPackage): | |||
| depends_on("libvdwxc~mpi", when="+libvdwxc") | |||
| depends_on("arpack-ng~mpi", when="+arpack") | |||
| depends_on("elpa~mpi", when="+elpa") | |||
| depends_on("netcdf-fortran ^netcdf-c~~mpi", when="+netcdf") | |||
| depends_on("netcdf-fortran", when="+netcdf") | |||
There was a problem hiding this comment.
since this line is repeated in both conditions (with and without mpi) its a good idea to push it out of the condition
|
added an MR upstream at spack/spack#40685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version seems to stun the concretizer (see #96)