improve portability of the UMD build:

- replace `self` with `globalThis` - make module detection more robust Co-authored-by: David Chambers <[email protected]>
fantasyland · Aug 2, 2021 · 766faf4 · 766faf4
1 parent 4b307da
commit 766faf4
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -10,6 +10,10 @@
         "no-undef": ["off"],
         "no-unused-vars": ["off"]
       }
+    },
+    {
+      "files": "index.js",
+      "globals": {"globalThis": false}
     }
   ]
 }
diff --git a/index.js b/index.js
@@ -28,10 +28,14 @@
   };
 
   /* istanbul ignore else */
-  if (typeof module === 'object' && typeof module.exports === 'object') {
+  if (
+    typeof module === 'object' &&
+    module != null &&
+    typeof module.exports === 'object'
+  ) {
     module.exports = mapping;
   } else {
-    self.FantasyLand = mapping;
+    globalThis.FantasyLand = mapping;
   }
 
 } ());
diff --git a/scripts/generate-js b/scripts/generate-js
@@ -11,10 +11,14 @@ cat >index.js <<EOF
   };
 
   /* istanbul ignore else */
-  if (typeof module === 'object' && typeof module.exports === 'object') {
+  if (
+    typeof module === 'object' &&
+    module != null &&
+    typeof module.exports === 'object'
+  ) {
     module.exports = mapping;
   } else {
-    self.FantasyLand = mapping;
+    globalThis.FantasyLand = mapping;
   }
 
 } ());