Upgrade CI test run to Emacs 29.3 (exercism#408)

* Upgrade CI test run to Emacs 29.3

* Fix failing tests because ERT now fails when redefining tests

> *** Redefining an ERT test in batch mode now signals an error.
> Executing 'ert-deftest' with the same name as an existing test causes
> the previous definition to be discarded, which was probably not
> intended when this occurs in batch mode.  To remedy the error, rename
> tests so that they all have unique names.

- https://github.com/emacs-mirror/emacs/blob/2c201bbba5c43328979bf139330684cacfa074f3/etc/NEWS.29#L933-L937

.github/workflows/ci.yml

@@ -13,7 +13,7 @@ jobs:
     steps:
       - uses: purcell/setup-emacs@c851e5408f2d2f657fa80375bbe3fb35029aa488
         with:
-          version: 28.2
+          version: 29.3
 
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.0.0
 

README.md

@@ -9,7 +9,7 @@
 This repo holds all the instructions, tests, code, & support files for Emacs Lisp _exercises_ currently under development or implemented & available for students.
 If you haven't already, you can check out and study the live language track [here][exercism-emacs-lisp-track].
 
-🌟   The test runner is currently running Emacs 28.2
+🌟   The test runner is currently running Emacs 29.3
 
 Currently the Emacs Lisp track doesn't feature a syllabus, so it only contains practice exercises. Practice exercises are open-ended problems that allow you to build and test your knowledge of a programming language. You can find the practice exercises referenced in the [config.json][config-json] and the files in the [`exercises/practice`][emacs-lisp-exercises-practice-dir] directory. The practice exercises are shared between tracks. You can find the canonical problem description in the [problem specifications repository][problem-specifications-repository].
 

exercises/practice/triangle/triangle-test.el

@@ -10,23 +10,23 @@
 (declare-function scalenep "triangle.el" (sides))
 
 
-(ert-deftest all-sides-are-equal ()
+(ert-deftest all-sides-are-equal-1 ()
   (should (equilateralp '(2 2 2))))
 
 
 (ert-deftest any-side-is-unequal ()
   (should-not (equilateralp '(2 3 2))))
 
 
-(ert-deftest no-sides-are-equal ()
+(ert-deftest no-sides-are-equal-1 ()
   (should-not (equilateralp '(5 4 6))))
 
 
 (ert-deftest all-zero-sides-is-not-a-triangle ()
   (should-not (equilateralp '(0 0 0))))
 
 
-(ert-deftest sides-may-be-floats ()
+(ert-deftest sides-may-be-floats-1 ()
   (should (equilateralp '(0.5 0.5 0.5))))
 
 
@@ -46,7 +46,7 @@
   (should (isoscelesp '(4 4 4))))
 
 
-(ert-deftest no-sides-are-equal ()
+(ert-deftest no-sides-are-equal-2 ()
   (should-not (isoscelesp '(2 3 4))))
 
 
@@ -62,15 +62,15 @@
   (should-not (isoscelesp '(3 1 1))))
 
 
-(ert-deftest sides-may-be-floats ()
+(ert-deftest sides-may-be-floats-2 ()
   (should (isoscelesp '(0.5 0.4 0.5))))
 
 
-(ert-deftest no-sides-are-equal ()
+(ert-deftest no-sides-are-equal-3 ()
   (should (scalenep '(5 4 6))))
 
 
-(ert-deftest all-sides-are-equal ()
+(ert-deftest all-sides-are-equal-2 ()
   (should-not (scalenep '(4 4 4))))
 
 
@@ -90,7 +90,7 @@
   (should-not (scalenep '(7 3 2))))
 
 
-(ert-deftest sides-may-be-floats ()
+(ert-deftest sides-may-be-floats-3 ()
   (should (scalenep '(0.5 0.4 0.6))))
 
 (provide 'triangle-test)