Add ID conversion check in CharacterFactory

lib/domains/character/CharacterFactory.test.tsx

@@ -2,8 +2,9 @@
 import { CharacterFactory } from "./CharacterFactory";
 import { DefaultTemplates } from "./DefaultTemplates";
 import { ComplexCharacter } from "./mocks/ComplexCharacter";
+import { DuplicateIds } from "./mocks/DuplicateIds";
 import { Warden } from "./mocks/WardenLeMagane";
-import { IV1Character } from "./types";
+import { ICharacter, IV1Character } from "./types";
 
 describe("CharacterFactory.migrate", () => {
   describe("v1", () => {
@@ -691,4 +692,27 @@
       });
     });
   });
+
+  it("should handle duplicate id imports", () => {
+    const result = CharacterFactory.makeFromJson(DuplicateIds);
+
+    const ids = [result.id];
+
+    for (const page of result.pages) {
+      ids.push(page.id);
+      for (const row of page.rows) {
+        for (const column of row.columns) {
+          for (const section of column.sections) {
+            ids.push(section.id);
+            for (const block of section.blocks) {
+              ids.push(block.id);
+            }
+          }
+        }
+      }
+    }
+
+    // This should check for duplicates
+    expect(new Set(ids).size).toEqual(ids.length);
+  });
 });

lib/domains/character/CharacterFactory.tsx

@@ -50,7 +50,7 @@ export const CharacterFactory = {
       default: undefined,
     };
     const migratedSheet = this.migrate(newSheet);
-    return migratedSheet;
+    return CharacterFactory.resetAllIds(migratedSheet);
   },
   migrate(character: any): ICharacter {
     try {