Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConcurrencyTest was not being executed, cleanup #85

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

ConcurrencyTest was not being executed, cleanup #85

wants to merge 12 commits into from

Conversation

leogtzr
Copy link
Contributor

@leogtzr leogtzr commented May 31, 2017

No description provided.

@leogtzr
Copy link
Contributor Author

leogtzr commented Jun 1, 2017

This change (#110cccb) helps to decouple "Operator" with its "precedence", in my opinion, "Operator" and its precedence should be separate, it smells like it is breaking single responsability principle, "Operator" is abstract and it is meant to be extended ... being able to access its class variables doesn't look right to me.
I have added a class with a non-instantiable idiom that holds precedence values.

@leogtzr
Copy link
Contributor Author

leogtzr commented Jun 1, 2017

I have refactored the code in Function.java class with an enum, this would help to avoid the coupling between class variables and the array, now we have all the logic in the enum ... we also got rid of indexing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant