-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConcurrencyTest was not being executed, cleanup #85
base: master
Are you sure you want to change the base?
Conversation
This change (#110cccb) helps to decouple "Operator" with its "precedence", in my opinion, "Operator" and its precedence should be separate, it smells like it is breaking single responsability principle, "Operator" is abstract and it is meant to be extended ... being able to access its class variables doesn't look right to me. |
I have refactored the code in Function.java class with an enum, this would help to avoid the coupling between class variables and the array, now we have all the logic in the enum ... we also got rid of indexing. |
No description provided.