Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM Support for FastPFOR using SIMDe #108

Merged
merged 71 commits into from
Jan 31, 2024
Merged

Add ARM Support for FastPFOR using SIMDe #108

merged 71 commits into from
Jan 31, 2024

Conversation

seb711
Copy link
Contributor

@seb711 seb711 commented Dec 27, 2023

This pull request introduces support for ARM architecture in the FastPFOR project, particularly for building on aarch64 devices. The need for ARM support arose while running FastPFOR on a Graviton Instance. After conducting research and consulting with my mentor at Technical University of Munich (TUM), we decided to integrate SIMDe.

This is a draft pull request, primarily to seek feedback and further insights. The current state of the code might not fully align with the repository's requirements, and due to time constraints, I couldn't perform exhaustive tests (FastPFOR_unittest and "make check" run without errors though). The purpose of this pull request is to share the progress with the community, especially for those interested in building the FastPFOR library on an AARCH64 machine.

@lemire
Copy link
Member

lemire commented Jan 15, 2024

Running tests.

@lemire
Copy link
Member

lemire commented Jan 15, 2024

@seb711 Can you have a quick look? Seems like it does not build for ARM...

@seb711
Copy link
Contributor Author

seb711 commented Jan 15, 2024

Hi, so I had only tested it for GCC and ARM and not VS-Compiler and ARM. Therefore I had to add the predefined compiler flags for MSC. Added the VS-ARM Workflow + Tests to the PR, so that the ARM build gets also tested.

Sorry for the delay, but i needed an alternative implementation for the rdtsc-call in MSC+ARM (couldn't use asm volatile)

@lemire
Copy link
Member

lemire commented Jan 27, 2024

@seb711 Ok. We can merge. Please confirm that you are happy with the PR as it stands.

@seb711
Copy link
Contributor Author

seb711 commented Jan 31, 2024

@lemire I'm happy with the PR as it stands by now (also worked with it in the last weeks and experienced no issues). I only have one concern: Until there is no Github Runner, that tests ARM runs with GCC, any future change related to ARM builds with GCC cannot be verified with the runners. Arm Runner are announced (https://github.blog/changelog/2023-10-30-accelerate-your-ci-cd-with-arm-based-hosted-runners-in-github-actions/), but are only in private beta by now .

@lemire
Copy link
Member

lemire commented Jan 31, 2024

I am merging.

@lemire lemire merged commit 5986b89 into fast-pack:master Jan 31, 2024
4 checks passed
@lemire lemire mentioned this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants