Clear trailing bytes in StreamVByte to ensure bit-exact output #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pps83
force-pushed
the
master-StreamVByte-padding
branch
from
34ee4bb to
2c446fc
Compare
StreamVByte codec rounds up output size to multiple of 4 bytes. As a result, up to 3 trailing bytes could be uninitialized memory passed to the encodeArray function. To ensure bitexact output, these padding bytes should be cleared.
pps83
force-pushed
the
master-StreamVByte-padding
branch
from
2c446fc to
006dc00
Compare
|
Looks reasonable!!! |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamVByte codec rounds up output size to multiple of 4 bytes. As a result, up to 3 trailing bytes could be uninitialized memory passed to the encodeArray function. To ensure bitexact output, these padding bytes should be cleared.