Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing unit property to ItemEntity class #51

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

HussamAlhennawi
Copy link
Contributor

@HussamAlhennawi HussamAlhennawi commented Nov 22, 2024

Hi,

I'm using the latest release 0.1.5, and got the following error when calling getInvoice(...) from InvoiceService class:

the provided xml key UNIT is not mapped at the moment in FastBillSdk\Item\ItemEntity

The missing property was added to the class, as well as to the mapping array, could you please check the changes and merge the PR?

Add unit mapping.
@teiling88 teiling88 merged commit e21e694 into fastbill:master Nov 23, 2024
0 of 2 checks passed
@teiling88
Copy link
Collaborator

Thank you for your contribution. It is merged and the new release is published: https://github.com/fastbill/fastbill-php-sdk/releases/tag/0.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants