Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use node: prefix to bypass require.cache call for builtins #658

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Sep 10, 2023

See fastify/fastify-static#407

Checklist

@Fdawgs
Copy link
Member Author

Fdawgs commented Sep 15, 2023

No cussing idea why the tests are failing.

@Fdawgs Fdawgs requested a review from Eomm October 22, 2023 09:40
@Fdawgs Fdawgs requested a review from a team October 28, 2023 10:48
@Eomm Eomm merged commit 7fe47ab into master Oct 30, 2023
40 checks passed
@Eomm Eomm deleted the perf/builtins branch October 30, 2023 19:43
bodinsamuel referenced this pull request in specfy/specfy Nov 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify-cli](https://togithub.com/fastify/fastify-cli) | [`5.8.0` ->
`5.9.0`](https://renovatebot.com/diffs/npm/fastify-cli/5.8.0/5.9.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify-cli/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify-cli/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify-cli/5.8.0/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify-cli/5.8.0/5.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-cli (fastify-cli)</summary>

###
[`v5.9.0`](https://togithub.com/fastify/fastify-cli/releases/tag/v5.9.0)

[Compare
Source](https://togithub.com/fastify/fastify-cli/compare/v5.8.0...v5.9.0)

#### What's Changed

- Replace pino-colada in help messages with pino-pretty by
[@&#8203;segevfiner](https://togithub.com/segevfiner) in
[https://github.com/fastify/fastify-cli/pull/659](https://togithub.com/fastify/fastify-cli/pull/659)
- Add an option to generate YAML to generate-swagger by
[@&#8203;segevfiner](https://togithub.com/segevfiner) in
[https://github.com/fastify/fastify-cli/pull/662](https://togithub.com/fastify/fastify-cli/pull/662)
- fix: app template options by
[@&#8203;lqqyt2423](https://togithub.com/lqqyt2423) in
[https://github.com/fastify/fastify-cli/pull/652](https://togithub.com/fastify/fastify-cli/pull/652)
- chore(deps-dev): bump sinon from 14.0.2 to 16.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-cli/pull/663](https://togithub.com/fastify/fastify-cli/pull/663)
- chore(deps-dev): bump fastify-tsconfig from 1.0.1 to 2.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-cli/pull/665](https://togithub.com/fastify/fastify-cli/pull/665)
- chore: update typescript version to v5 by
[@&#8203;DemonHa](https://togithub.com/DemonHa) in
[https://github.com/fastify/fastify-cli/pull/672](https://togithub.com/fastify/fastify-cli/pull/672)
- chore: add missing `use strict` directives by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cli/pull/673](https://togithub.com/fastify/fastify-cli/pull/673)
- chore(deps-dev): bump sinon from 16.1.3 to 17.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-cli/pull/675](https://togithub.com/fastify/fastify-cli/pull/675)
- chore(deps-dev): bump concurrently from 7.6.0 to 8.2.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-cli/pull/676](https://togithub.com/fastify/fastify-cli/pull/676)
- test: optimize split params by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cli/pull/674](https://togithub.com/fastify/fastify-cli/pull/674)
- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cli/pull/677](https://togithub.com/fastify/fastify-cli/pull/677)
- perf: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-cli/pull/658](https://togithub.com/fastify/fastify-cli/pull/658)

#### New Contributors

- [@&#8203;lqqyt2423](https://togithub.com/lqqyt2423) made their first
contribution in
[https://github.com/fastify/fastify-cli/pull/652](https://togithub.com/fastify/fastify-cli/pull/652)
- [@&#8203;DemonHa](https://togithub.com/DemonHa) made their first
contribution in
[https://github.com/fastify/fastify-cli/pull/672](https://togithub.com/fastify/fastify-cli/pull/672)

**Full Changelog**:
fastify/fastify-cli@v5.8.0...v5.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants