-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Test script cannot detect test under test directory with deep level #708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Matteo Collina <[email protected]> Signed-off-by: adamward459 <[email protected]>
Can you retry the window job @mcollina ? i don't know what went wrong with it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This change seems to break node versions <21 for me when running |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct
System information
The demo can be found here
Mac os: 14.3.1 (23D60)
Node: v21.6.2
Npm: 10.2.4
Reproduce
List all tests under the test directory
➜ demo-fastify git:(main) find ./test -name "*.test.ts" ./test/plugins/support.test.ts ./test/routes/example.test.ts ./test/routes/root.test.ts ./test/routes/routes/example.test.ts ./test/routes/routes/root.test.ts ./test/routes/routes/routes/example.test.ts ./test/routes/routes/routes/root.test.ts
Run
test
command, the test command can only figure out files at first level.After I change the pattern to include double quote mark, here is the result: