fix: allow fallback to [email protected] route config #410

climba03003 · 2023-09-16T22:48:38Z

Closes #411

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

index.js

* fix: request route config deprecation * Add version constraint * Update version requirement Co-authored-by: KaKa <[email protected]> * Fix versioning --------- Co-authored-by: KaKa <[email protected]>

Uzlopak

LGTM, decide if you want to apply the suggestion of @gurgunday

gurgunday

I think it should be req.routeOptions.config instead of req.routeConfig.config

Uzlopak · 2023-09-16T23:51:14Z

Very good catch!

Co-authored-by: Gürgün Dayıoğlu <[email protected]>

Uzlopak · 2023-09-17T00:03:31Z

Ok, tested it locally thoroughly, by using fastify 4.20.0 and it works. updated to latest, works and does not emit warnings. modified that line to use a different key with latest fastify, emitted warnings.

Uzlopak · 2023-09-17T00:03:41Z

@gurgunday
PTAL

mcollina

lgtm

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/static](https://togithub.com/fastify/fastify-static) | [`6.11.1` -> `6.11.2`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.11.1/6.11.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/6.11.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/6.11.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.11.1/6.11.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.11.1/6.11.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-static (@fastify/static)</summary> ### [`v6.11.2`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.2) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.1...v6.11.2) #### What's Changed - fix: allow fallback to [email protected] route config by [@climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify-static/pull/410](https://togithub.com/fastify/fastify-static/pull/410) **Full Changelog**: fastify/fastify-static@v6.11.1...v6.11.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominic Saadi <[email protected]>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/static](https://togithub.com/fastify/fastify-static) | [`6.11.1` -> `6.11.2`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.11.1/6.11.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/6.11.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/6.11.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.11.1/6.11.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.11.1/6.11.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>fastify/fastify-static (@fastify/static)</summary> [`v6.11.2`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.2) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.1...v6.11.2) - fix: allow fallback to [email protected] route config by [@climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify-static/pull/410](https://togithub.com/fastify/fastify-static/pull/410) **Full Changelog**: fastify/fastify-static@v6.11.1...v6.11.2 </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominic Saadi <[email protected]>

fix: allow fallback to [email protected] route config

846c984

gurgunday reviewed Sep 16, 2023

View reviewed changes

index.js Outdated Show resolved Hide resolved

Uzlopak approved these changes Sep 16, 2023

View reviewed changes

gurgunday requested changes Sep 16, 2023

View reviewed changes

Apply suggestions from code review

e3c8825

Co-authored-by: Gürgün Dayıoğlu <[email protected]>

gurgunday approved these changes Sep 17, 2023

View reviewed changes

mcollina approved these changes Sep 17, 2023

View reviewed changes

Eomm approved these changes Sep 17, 2023

View reviewed changes

Eomm merged commit 8d0c3be into master Sep 17, 2023
17 checks passed

Eomm deleted the fix-breaking branch September 17, 2023 08:25

Eomm mentioned this pull request Sep 17, 2023

fix nestjs fastify platform warn fastify/fastify-helmet#231

Merged

4 tasks

johanbook mentioned this pull request Jul 6, 2024

[Snyk] Upgrade @fastify/static from 6.11.2 to 6.12.0 johanbook/meet#787

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: allow fallback to [email protected] route config #410

fix: allow fallback to [email protected] route config #410

climba03003 commented Sep 16, 2023 •

edited by gurgunday

Loading

Uzlopak left a comment

gurgunday left a comment

Uzlopak commented Sep 16, 2023

Uzlopak commented Sep 17, 2023

Uzlopak commented Sep 17, 2023

mcollina left a comment

fix: allow fallback to [email protected] route config #410

fix: allow fallback to [email protected] route config #410

Conversation

climba03003 commented Sep 16, 2023 • edited by gurgunday Loading

Checklist

Uzlopak left a comment

Choose a reason for hiding this comment

gurgunday left a comment

Choose a reason for hiding this comment

Uzlopak commented Sep 16, 2023

Uzlopak commented Sep 17, 2023

Uzlopak commented Sep 17, 2023

mcollina left a comment

Choose a reason for hiding this comment

climba03003 commented Sep 16, 2023 •

edited by gurgunday

Loading