Fix RemoveIdentityOps not correctly handling ops following fork-nodes #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change in the import and built-in functions.
13 tasks
This is required for supporting scaled dot-product attention, which has 3 dimensional tensors with batch/head, sequence and embedding dimension.
…ata_layouts Introduce 3D layout annotations defaulting to NWC
….],[ch0_max, ch1_max,..])
…x/tf2onnx-1.16.1 Try newer tf2onnx version to get CI back in green
…mport_in_notebook_0 fix notebook 0
QuantLSTM (ONNX) QCDQ representation
….com/makoeppel/qonnx into makoeppel-improve/test_conv_lowering_convmnist
…t_conv_lowering_convmnist Improve/test conv lowering convmnist
random input generated with seed=42 was causing a major difference in Conv_13_out0 for no apparent reason (probably float / numerical related)
…eature/convlower_qnt Preserve weight quantizer while lowering convolutions
Remove some commented debug code
…eature/test_a2q_nets Add easy fetch of accumulator-aware quantized (A2Q) CIFAR-10 models for testing
…iksnagreb/qonnx into iksnagreb-feature/sort_commutative_inputs
…_commutative_inputs Add cleanup transformation sorting inputs of commutative operations
…b/qonnx into iksnagreb-fix/remove_identity_ops
|
LGTM. Thanks @iksnagreb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue reported here #86, by adding a missing test for the producer node being a fork node. Added some (probably too extensive) documentation and a new check to avoid removing join-node operations by accident (currently not possible, but this was not really documented).
Closes #86