Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1122 - working under WSL2, Ruby 3.0.6 #1135

Closed

Conversation

ferrisoxide
Copy link
Contributor

@ferrisoxide ferrisoxide commented Jul 25, 2023

Various small fixes to get FatFreeCRM installing under WSL using Postgres and Ruby 3.0.6

NB Updating Ruby appears necessary - at least on WSL - to get mini_racer to install. It assumes use of the geckodriver for executing feature specs via modern Firefox.

This also attempts to fix #1122

This is my first PR for FatFreeCRM, so I'm not sure if pushing an update to the Ruby version, etc is compatible with what the community is after.

@ferrisoxide ferrisoxide changed the title working under wsl, ruby 3.0.6 WIP: Working under wsl, ruby 3.0.6 Jul 25, 2023
@ferrisoxide ferrisoxide changed the title WIP: Working under wsl, ruby 3.0.6 Working under wsl, ruby 3.0.6 Jul 26, 2023
fix i18n

fix selenium specs
@ferrisoxide ferrisoxide changed the title Working under wsl, ruby 3.0.6 Fix for #1122 - working under WSL2, Ruby 3.0.6 Jul 26, 2023
@nelsonmatenda
Copy link

it worked...

@CloCkWeRX
Copy link
Member

Basically the standard for if a PR is worth it is if it's fixing a problem :)

I would maybe suggest splitting upgrades vs other issues, maybe using an issue to track the big picture.

But, let me take a bit of a look

@ferrisoxide
Copy link
Contributor Author

I would maybe suggest splitting upgrades vs other issues, maybe using an issue to track the big picture.

OK, I'll look at splitting these into separate PRs. K++

@ferrisoxide
Copy link
Contributor Author

Closing this PR in favour of separate issue-specific PRs. See

@ferrisoxide
Copy link
Contributor Author

ferrisoxide commented Aug 2, 2023

@nelsonmatenda

it worked...

The same fixes have been moved into separate PRs (#1137, #1139). Hopefully together it still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running migration 20230526212613_convert_to_active_storage.rb
3 participants