Prep 0.22.1 #1337
Merged
Prep 0.22.1 #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.17.0 to 1.17.1. - [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md) - [Commits](Shopify/bootsnap@v1.17.0...v1.17.1) --- updated-dependencies: - dependency-name: bootsnap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…1.17.1 Bump bootsnap from 1.17.0 to 1.17.1
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.59.0 to 1.60.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.59.0...v1.60.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
….60.0 Bump rubocop from 1.59.0 to 1.60.0
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.60.0 to 1.60.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.60.0...v1.60.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
….60.1 Bump rubocop from 1.60.0 to 1.60.1
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.60.1 to 1.60.2. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.60.1...v1.60.2) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
….60.2 Bump rubocop from 1.60.1 to 1.60.2
Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 6.1.0 to 6.1.1. - [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md) - [Commits](rspec/rspec-rails@v6.1.0...v6.1.1) --- updated-dependencies: - dependency-name: rspec-rails dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.39.2 to 3.40.0. - [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md) - [Commits](teamcapybara/capybara@3.39.2...3.40.0) --- updated-dependencies: - dependency-name: capybara dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…3.40.0 Bump capybara from 3.39.2 to 3.40.0
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.17.1 to 1.18.1. - [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md) - [Commits](Shopify/bootsnap@v1.17.1...v1.18.1) --- updated-dependencies: - dependency-name: bootsnap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…1.18.1 Bump bootsnap from 1.17.1 to 1.18.1
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.18.1 to 1.18.3. - [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md) - [Commits](Shopify/bootsnap@v1.18.1...v1.18.3) --- updated-dependencies: - dependency-name: bootsnap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…1.18.3 Bump bootsnap from 1.18.1 to 1.18.3
Bumps [brakeman](https://github.com/presidentbeef/brakeman) from 6.1.1 to 6.1.2. - [Release notes](https://github.com/presidentbeef/brakeman/releases) - [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md) - [Commits](presidentbeef/brakeman@v6.1.1...v6.1.2) --- updated-dependencies: - dependency-name: brakeman dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…6.1.2 Bump brakeman from 6.1.1 to 6.1.2
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.0 to 1.16.2. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.16.0...v1.16.2) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…1.16.2 Bump nokogiri from 1.16.0 to 1.16.2
Bumps [pg](https://github.com/ged/ruby-pg) from 1.5.4 to 1.5.5. - [Changelog](https://github.com/ged/ruby-pg/blob/master/History.md) - [Commits](ged/ruby-pg@v1.5.4...v1.5.5) --- updated-dependencies: - dependency-name: pg dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [country_select](https://github.com/countries/country_select) from 8.0.3 to 9.0.0. - [Release notes](https://github.com/countries/country_select/releases) - [Changelog](https://github.com/countries/country_select/blob/master/CHANGELOG.md) - [Commits](countries/country_select@v8.0.3...v9.0.0) --- updated-dependencies: - dependency-name: country_select dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…elect-9.0.0 Bump country_select from 8.0.3 to 9.0.0
Correct font-sizes for mobile views using dl layouts.
Fix layout of custom field inputs. Now consistent with other form inputs
…oved readability of specs
Fix custom fields checkbox list
…oup-of-2 Use group view for custom fields
…es they are 'seen' by ActiveRecord whe autoloading (usually in development mode) is turned on.
Bumps [premailer](https://github.com/premailer/premailer) from 1.24.0 to 1.25.0. - [Changelog](https://github.com/premailer/premailer/blob/master/CHANGELOG.md) - [Commits](premailer/premailer@v1.24.0...v1.25.0) --- updated-dependencies: - dependency-name: premailer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…-1.25.0 Bump premailer from 1.24.0 to 1.25.0
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.3 to 3.3.6. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.3...v3.3.6) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bump rexml from 3.3.3 to 3.3.6
…tered custom_fields in development mode. Added strong params to custom fields. Improve specs.
Fix bug prevening creation or update of custom field pairs. Refactor 'pair' code.
…utocomplete Fix Opportunities Campaign selection auto complete
Bumps [brakeman](https://github.com/presidentbeef/brakeman) from 6.1.2 to 6.2.1. - [Release notes](https://github.com/presidentbeef/brakeman/releases) - [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md) - [Commits](presidentbeef/brakeman@v6.1.2...v6.2.1) --- updated-dependencies: - dependency-name: brakeman dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Settings attributes are unknown at runtime so must be arbitarily whitelisted
…6.2.1 Bump brakeman from 6.1.2 to 6.2.1
Deleting a campaign shouldn't delete related leads and opportunities.
Added a placeholder to ensure the 'x' button works on Select2 dropdown
Bumps [acts-as-taggable-on](https://github.com/mbleigh/acts-as-taggable-on) from 10.0.0 to 11.0.0. - [Release notes](https://github.com/mbleigh/acts-as-taggable-on/releases) - [Changelog](https://github.com/mbleigh/acts-as-taggable-on/blob/master/CHANGELOG.md) - [Commits](mbleigh/acts-as-taggable-on@v10.0.0...v11.0.0) --- updated-dependencies: - dependency-name: acts-as-taggable-on dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [premailer](https://github.com/premailer/premailer) from 1.25.0 to 1.26.0. - [Changelog](https://github.com/premailer/premailer/blob/master/CHANGELOG.md) - [Commits](premailer/premailer@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: premailer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…-1.26.0 Bump premailer from 1.25.0 to 1.26.0
…aggable-on-11.0.0 Bump acts-as-taggable-on from 10.0.0 to 11.0.0
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| end | ||
|
|
||
| def pair_params | ||
| params.require(:pair).permit("0": [:hint, :required, :disabled, :id], "1": [:hint, :required, :disabled, :id]) |
Check notice
Code scanning / Rubocop
Use %i or %I for arrays of symbols. Note
| end | ||
|
|
||
| def pair_params | ||
| params.require(:pair).permit("0": [:hint, :required, :disabled, :id], "1": [:hint, :required, :disabled, :id]) |
Check notice
Code scanning / Rubocop
Use %i or %I for arrays of symbols. Note
|
|
||
| link_to(t(:delete) + "!", | ||
| options[:url] || url_for(record), | ||
| method: :delete, | ||
| remote: true, | ||
| confirm: confirm) | ||
| data: { confirm: confirm }) |
Check notice
Code scanning / Rubocop
Prefer Ruby 1.9 hash syntax { a: 1, b: 2 } over 1.8 syntax { :a => 1, :b => 2 }. Note
| require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') | ||
|
|
||
| describe Admin::FieldsController do | ||
|
|
Check notice
Code scanning / Rubocop
Keeps track of empty lines around block bodies. Note test
| @params = { 'id' => '3', 'field' => @field, 'pair' => { '0' => @pair1, '1' => @pair2 } } | ||
| end | ||
| let!(:field1) { CustomFieldPair.create!(name: 'cf_pair1', label: 'Date Pair', as: 'date_pair', hint: "", field_group: field_group, required: false, disabled: 'false') } | ||
| let!(:field2) { CustomFieldPair.create!(name: 'cf_pair2', label: 'Date Pair', as: 'date_pair', hint: "", field_group: field_group, required: false, disabled: 'false', pair_id: field1.id) } |
Check notice
Code scanning / Rubocop
Prefer Ruby 1.9 hash syntax { a: 1, b: 2 } over 1.8 syntax { :a => 1, :b => 2 }. Note test
| @field1 = CustomFieldDatePair.new(name: 'cf_event_from') | ||
| @field2 = CustomFieldDatePair.new(name: 'cf_event_to') | ||
| end | ||
| let!(:field1) { CustomFieldPair.create!(name: 'cf_event_from', label: 'From', as: 'date_pair', field_group: field_group) } |
Check notice
Code scanning / Rubocop
Prefer Ruby 1.9 hash syntax { a: 1, b: 2 } over 1.8 syntax { :a => 1, :b => 2 }. Note test
| @field2 = CustomFieldDatePair.new(name: 'cf_event_to') | ||
| end | ||
| let!(:field1) { CustomFieldPair.create!(name: 'cf_event_from', label: 'From', as: 'date_pair', field_group: field_group) } | ||
| let!(:field2) { CustomFieldPair.create!(name: 'cf_event_to', label: 'To', as: 'date_pair', field_group: field_group, pair_id: field1.id) } |
Check notice
Code scanning / Rubocop
Prefer Ruby 1.9 hash syntax { a: 1, b: 2 } over 1.8 syntax { :a => 1, :b => 2 }. Note test
| ) | ||
| object = double('Object') | ||
| context "render" do | ||
| let(:field) { FactoryBot.create(:field, as: as) } |
Check notice
Code scanning / Rubocop
Prefer Ruby 1.9 hash syntax { a: 1, b: 2 } over 1.8 syntax { :a => 1, :b => 2 }. Note test
| end | ||
| end | ||
|
|
Check notice
Code scanning / Rubocop
Keeps track of empty lines around block bodies. Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1336