Add test to Django command retry_sage_transactions #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/270-add-tests-retry-transaction
branch
2 times, most recently
from
d756938 to
5172d5b
Compare
- Removed the command functionality from the command layer - Added tests to the command logic
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/270-add-tests-retry-transaction
branch
from
5172d5b to
3a40f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors retry sending transaction and increase the tests coverage.
Removed the command functionality from the command layer
TransactionServicelayer which is the component aimed to handle transaction resources. Refactored intended to follow the single responsibility principle and provide loose coupling for testing.Added tests to the command logic
TransactionService.This PR is related to #270