-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying a bit weighting of completion list SmartMatch #1173
base: development
Are you sure you want to change the base?
Conversation
…artMatch. Collateral damage is that abbreviation matching is now only enabled for all-uppercase words.
@Neverbirth, @SlavaRa, @wise0704, comments? |
I think I completely missed this PR until now... not a part of code I really know. I'd need to try out how the completion feel with the abbreviation change, by looking at the changes it seems to me the issue is already fixed without that behaviour change? |
It needs unit tests as well, because the weighting was changed a bit randomly. |
@elsassph: Will you add tests here or should we merge as such? |
We shouldn't merge without tests I believe. I'll try to do it quickly. |
@elsassph, any progress? :) |
Well... I haven't been able to run tests at all so far :/ |
Any progress? |
Fixes issue #1161
Note: collateral damage is that abbreviation matching is now only enabled for all-uppercase words.