Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support haxe final keyword #2971

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Conversation

romamik
Copy link
Contributor

@romamik romamik commented Jan 27, 2020

Support haxe final keyword for variable completion and coloring.
Resolves #2775 and partially resolves #1925 (does not support final as method modifier.)

r.miklashevski and others added 2 commits January 27, 2020 18:18
@SlavaRa
Copy link

SlavaRa commented Jan 30, 2020

@romamik should this work under haxe < 4.0.0?

@romamik
Copy link
Contributor Author

romamik commented Jan 30, 2020

I did not test with older haxe versions. IMHO it should not break anything, but may display final in autocompletion list.

@SlavaRa
Copy link

SlavaRa commented Jan 30, 2020

I did not test with older haxe versions. IMHO it should not break anything, but may display final in autocompletion list.

I would not be so sure without the tests :)
This shouldn't work for versions < 4.0.0

@romamik
Copy link
Contributor Author

romamik commented Jan 30, 2020

Do you mean to enable/disable this code depending on haxe version? Is there some example of how can this be accomplished?

@romamik
Copy link
Contributor Author

romamik commented Jan 31, 2020

I've added version check. Now final is not shown in completion if haxe version is < 4. Also I've tested with haxe 3.4.7.

Not sure if the way I add/remove/check item existense in features.codeKeywords and features.declKeywords arrays is correct.

@SlavaRa
Copy link

SlavaRa commented Mar 27, 2020

@romamik i'll check and merge today.

@SlavaRa SlavaRa self-assigned this Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Haxe4] Auto-indent wrong after final keyword [Haxe4] Support for final keyword
2 participants