Avoid unnecessary queries to n_faces() #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was impressed by the large times we had during the assembly so I quickly profiled with Kcachegrind. Here's the call-graph with the current master:
The function
n_faces()
(the function which checks the number of faces for an agglomerate) was accidentally called multiple times during theneighbor_of_agglomerated_neighbor()
. With this fix the number of calls ton_faces()
is now equal to the number of calls toneighbor_of_agglomerated_neighbor
(i.e. 780 in the next picture).This also highlights other costly calls.
@luca-heltai