Add import-locality to the set of FSD rules
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 20b5ecf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
daniilsapa
reviewed
Dec 9, 2024
| </details> | ||
|
|
||
| ### Migration from 0.4.0 | ||
|
|
||
| Version 0.5.0 introduced a new config file format. Follow the [instructions](../../MIGRATION_GUIDE.md) to migrate your config file. |
There was a problem hiding this comment.
This will lead to broken links in packages/steiger/README.md as we have these documents only on the top level of the repository. Is that ok?
There was a problem hiding this comment.
That's a good point. I think there's not a lot we can do about it for now, since this README is published to npm, and there we have no MIGRATION_GUIDE.md file at all, so this link is bound to be broken until we make a documentation site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #142 (won't close it, we'll close it manually when we release). We forgot to add that rule to the array of all rules