Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app layer to exceptions of no-layer-public-api rule #57

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Add app layer to exceptions of no-layer-public-api rule #57

merged 4 commits into from
Jul 17, 2024

Conversation

daniilsapa
Copy link
Collaborator

@daniilsapa daniilsapa commented Jul 16, 2024 •
edited
Loading

Resolves #55

@daniilsapa
Copy link
Collaborator Author

@illright
Could you tell me how I can test Steiger locally? How do you usually do that? I tried to run turbo build and then run dist/cli.js file but got an error.

@illright
Copy link
Member

Weird, what error did you get?

illright
illright requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great PR, thanks! A few corrections from my side

packages/steiger-plugin-fsd/src/no-layer-public-api/README.md Outdated Show resolved Hide resolved
.changeset/fair-ducks-hope.md Outdated Show resolved Hide resolved
packages/steiger-plugin-fsd/src/no-layer-public-api/index.ts Show resolved Hide resolved
@daniilsapa daniilsapa force-pushed the feature/index-file-exception-for-app branch from 9027a40 to f9c54ae Compare July 17, 2024 13:13
@daniilsapa daniilsapa force-pushed the feature/index-file-exception-for-app branch from f9c54ae to 4165332 Compare July 17, 2024 13:14
@daniilsapa
Copy link
Collaborator Author

The error occurs when you try to specify a folder that is outside the working folder. This is true for both local and distributed app builds.

Here's what it looks like

Screenshot 2024-07-17 at 16 23 09

@daniilsapa daniilsapa requested a review from illright July 17, 2024 13:27
illright
illright approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the corrections! As for the issues you're facing in development, it's weird, I've never seen it before. Could you make an issue about it, so that we don't lose this conversation?

@illright illright merged commit b1866e8 into feature-sliced:master Jul 17, 2024
7 checks passed
@daniilsapa daniilsapa deleted the feature/index-file-exception-for-app branch July 18, 2024 09:34
@daniilsapa
Copy link
Collaborator Author

You're welcome. Yes, I created an issue for that error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illright illright illright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an exception for an index file inside the App layer
2 participants
@daniilsapa @illright