Skip to content

Commit

Permalink
Don't wait for jobs in SmartImportTests
Browse files Browse the repository at this point in the history
Remove calls to waitForJobs(...) in SmartImportTests and join the
SmartImportJob instead.

Fixes: eclipse-platform#1427
Fixes: eclipse-platform#1807
  • Loading branch information
fedejeanne committed Apr 10, 2024
1 parent 41e1e3f commit bfbdf4f
Showing 1 changed file with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,7 @@ private void proceedSmartImportWizard(SmartImportWizard wizard, Consumer<SmartIm
assertNotNull(okButton);
processEventsUntil(() -> okButton.isEnabled(), -1);
wizard.performFinish();
waitForJobs(100, 1000); // give the job framework time to schedule the job
wizard.getImportJob().join();
waitForJobs(100, 5000); // give some time for asynchronous workspace jobs to complete
} finally {
if (!dialog.getShell().isDisposed()) {
dialog.close();
Expand Down Expand Up @@ -443,9 +441,7 @@ public void testChangedWorkingSets() throws Exception {
processEvents();
processEventsUntil(() -> okButton.isEnabled(), -1);
wizard.performFinish();
waitForJobs(100, 1000); // give the job framework time to schedule the job
wizard.getImportJob().join();
waitForJobs(100, 5000); // give some time for asynchronous workspace jobs to complete
assertEquals("WorkingSet2 should be selected", Collections.singleton(workingSet2),
page.getSelectedWorkingSets());
assertEquals("Projects were not added to working set", 1, workingSet2.getElements().length);
Expand Down

0 comments on commit bfbdf4f

Please sign in to comment.