api: require Authentication header when configured #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jpodivin
reviewed
Oct 8, 2024
so we can run it securely without being bombed by bots if LOGDETECTIVE_TOKEN is not set, the authentication check is disabled for sake of local development Signed-off-by: Tomas Tomecek <[email protected]>
TomasTomecek
force-pushed
the
require-api-token
branch
from
6f0260a
to
d4f89a6
Compare
jpodivin
reviewed
Oct 8, 2024
Comment on lines
+78
to
+79
| LOG.info("LOGDETECTIVE_TOKEN env var is set (%s), clien token = %s", | ||
| API_TOKEN, token) |
There was a problem hiding this comment.
Just maybe not print the token value.
There was a problem hiding this comment.
Why not? these are our logs; if someone can see that log, they can certainly access podman (and see the env var set there) or have shell access already.
Printing both values will make debugging much easier in case of issues.
There was a problem hiding this comment.
Well if that's ok with you I'm not going to hold this PR over it.
jpodivin
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we can run it securely without being bombed by bots
if LOGDETECTIVE_TOKEN is not set, the authentication check is disabled
for sake of local development