Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workflow): only upload bottle artifacts on merge #24

Merged
merged 1 commit into from
Dec 28, 2023
Merged

fix(workflow): only upload bottle artifacts on merge #24

merged 1 commit into from
Dec 28, 2023

Conversation

kate-goldenring
Copy link
Collaborator

We don't need to be pushing artifacts for PR actions only on push to main. This should prevent these workflow errors

With the provided path, there will be 2 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

@kate-goldenring kate-goldenring mentioned this pull request Dec 26, 2023
Merged
@kate-goldenring kate-goldenring merged commit b5483fd into fermyon:main Dec 28, 2023
3 checks passed
@kate-goldenring kate-goldenring deleted the only-upload-artifact-on-merge branch December 28, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthik2804 karthik2804 karthik2804 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kate-goldenring @karthik2804