-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optional frontmatter logo for page #1888
Conversation
Add Logo and LogoConfiguration types
If present, use the frontmatter logo on the page
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
🌿 Preview your docs: https://fern-preview-69a9e884-e92a-4bd2-817a-5d8be0bcc97c.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-2c0eea8a-c9b4-434f-bdc5-e759c093e8d2.docs.buildwithfern.com |
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
🌿 Preview your docs: https://fern-preview-f4ff8970-d8cf-4895-bc28-8a2976684f02.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-73a64114-974e-40fe-97af-3163dbb36c3d.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-965ffa74-314d-43cb-a4f1-a80a846240f9.docs.buildwithfern.com |
Playwright test resultsDetails 103 tests across 10 suites Flaky testschromium › forward-proxy/nextjs.spec.ts › capture the flag Skipped testschromium › posthog.spec.ts › Posthog loads successfully |
Addresses FER-3742
Short description of the changes made
Logos can now be configured custom for a specific page, by adding the logo to the frontmatter. The frontmatter takes either a single logo, or logos for both the light and dark themes. Urls and local images are both supported.
What was the motivation & context behind this PR?
A logo override for a specific page previously had to be done via custom js, and often resulted in components flashing as the default logo was overridden.
How has this PR been tested?
Tested locally with changes in Fern CLI ((PR here). Tested with single logo, light logo, and dark logo.