Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optional frontmatter logo for page #1888

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

sbelkadi
Copy link
Contributor

@sbelkadi sbelkadi commented Dec 12, 2024

Addresses FER-3742

Short description of the changes made

Logos can now be configured custom for a specific page, by adding the logo to the frontmatter. The frontmatter takes either a single logo, or logos for both the light and dark themes. Urls and local images are both supported.

What was the motivation & context behind this PR?

A logo override for a specific page previously had to be done via custom js, and often resulted in components flashing as the default logo was overridden.

How has this PR been tested?

Tested locally with changes in Fern CLI ((PR here). Tested with single logo, light logo, and dark logo.

Sami Belkadi added 3 commits December 12, 2024 11:14
Add Logo and LogoConfiguration types
If present, use the frontmatter logo on the page
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Dec 12, 2024 4:24pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Dec 12, 2024 4:24pm

Copy link

Copy link

@sbelkadi sbelkadi had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 12, 2024 16:26 — with GitHub Actions Failure
Copy link

github-actions bot commented Dec 12, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Dec 12, 2024

PR Preview

Copy link

@abvthecity abvthecity had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 13, 2024 02:59 — with GitHub Actions Failure
@abvthecity abvthecity marked this pull request as ready for review December 13, 2024 03:11
@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com December 13, 2024 03:11 — with GitHub Actions Error
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com December 13, 2024 03:11 — with GitHub Actions Error
@abvthecity abvthecity enabled auto-merge (squash) December 13, 2024 03:11
Copy link

Copy link

Copy link

Playwright test results

passed  98 passed
flaky  1 flaky
skipped  4 skipped

Details

stats  103 tests across 10 suites
duration  1 minute, 9 seconds
commit  f0a8d73

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request
chromium › websockets/websocket.spec.ts › websocket test

@abvthecity abvthecity merged commit 8605b12 into main Dec 13, 2024
19 of 21 checks passed
@abvthecity abvthecity deleted the sbelkadi/FER-3743-frontmatter-logo branch December 13, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants