Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(php): Handle cross package type names #5395

Merged
merged 4 commits into from
Dec 12, 2024
Merged

fix(php): Handle cross package type names #5395

merged 4 commits into from
Dec 12, 2024
+55 −16

Conversation

ajgateno
Copy link
Contributor

The PHP SDK generator doesn't handle naming conflicts arising from type imports. This PR solves this by using fully qualified paths when conflicts might arise.

@ajgateno ajgateno marked this pull request as ready for review December 12, 2024 16:41
@ajgateno ajgateno requested a review from dsinghvi as a code owner December 12, 2024 16:41
amckinney
amckinney approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@amckinney amckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution! The fact that PHP lets you do this is great 👏

Only nits, feel free to take them or leave them. Plus, don't forget to set the versions.yml to release a patch!

generators/php/codegen/src/ast/ClassReference.ts Outdated Show resolved Hide resolved
generators/php/codegen/src/ast/core/Writer.ts Outdated Show resolved Hide resolved
generators/php/codegen/src/ast/core/Writer.ts Outdated Show resolved Hide resolved
generators/php/codegen/src/ast/core/Writer.ts Outdated Show resolved Hide resolved
generators/php/codegen/src/ast/core/Writer.ts Outdated Show resolved Hide resolved
@ajgateno ajgateno force-pushed the alberto/fix-php-cross-package-names branch from 5cdc78b to 7a0082d Compare December 12, 2024 20:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited by dannysheridan
Loading

🌿 Preview your docs: https://fern-preview-5203687a-cebe-4204-913e-371310ab9e34.docs.buildwithfern.com/learn

@ajgateno ajgateno enabled auto-merge (squash) December 12, 2024 20:57
@ajgateno ajgateno merged commit 7c73af2 into main Dec 12, 2024
51 of 52 checks passed
@ajgateno ajgateno deleted the alberto/fix-php-cross-package-names branch December 12, 2024 20:58
@dannysheridan dannysheridan mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amckinney amckinney amckinney approved these changes

@dsinghvi dsinghvi Awaiting requested review from dsinghvi dsinghvi is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajgateno @amckinney