Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript): Add support for inlining path parameters #5408

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(typescript): Add support for inlining path parameters #5408

wants to merge 8 commits into from
+4,283,228 −5,176

Conversation

Swimburger
Copy link
Member

Description

Inline path parameters into request types by setting inlinePathParameters to true in the generator config.

Testing

  • Seed testing

@Swimburger Swimburger requested a review from dsinghvi as a code owner December 13, 2024 18:29
@Swimburger Swimburger changed the title feat(ts): Add support for inlining path parameters feat(typescript): Add support for inlining path parameters Dec 13, 2024
amckinney
amckinney approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@amckinney amckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the service-level path parameters are handled well, this looks great to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amckinney amckinney amckinney approved these changes

@dsinghvi dsinghvi Awaiting requested review from dsinghvi dsinghvi is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swimburger @amckinney