Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing encoding issues - avoid text gabling #9

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

stankut
Copy link
Contributor

@stankut stankut commented Mar 16, 2017

during the import some of the text was garbled. For example, the import of this article https://www.borger.dk/arbejde-dagpenge-ferie/Dagpenge-kontanthjaelp-og-sygedagpenge/Kontanthjaelp/Kontanthjaelp-30-eller-derover, and more specifically microarticle "Jobparat – hvad skal jeg?", resulted in "Jobparat ? hvad skal jeg?"

the change above fixes those issues

stankut added 2 commits March 16, 2017 08:05
during the import some of the text was garbled. For example, the import of this article https://www.borger.dk/arbejde-dagpenge-ferie/Dagpenge-kontanthjaelp-og-sygedagpenge/Kontanthjaelp/Kontanthjaelp-30-eller-derover, and more specifically microarticle "Jobparat – hvad skal jeg?", resulted in "Jobparat ? hvad skal jeg?"

the change above fixes those issues
@beltofte
Copy link
Member

Hi Stanislav,

Removing utf8_decode() is causing encoding issues in our D8 implementation - just tested and it looks quite bad :-) Does not have time right now to debug this and fix it - fully booked with client work.

A solution could be that you fork this repo and use a dev-bugfix branch in Composer like described here https://getcomposer.org/doc/05-repositories.md#vcs. It should make it possible to get your fork installed when using Composer.

Best regards,
Jens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants