Skip to content

Commit

Permalink
* st.c (do_hash): it's the time to remove cast to unsigned int.
Browse files Browse the repository at this point in the history
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34321 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
  • Loading branch information
nobu committed Jan 17, 2012
1 parent 07b9002 commit 270ac46
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
4 changes: 4 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Tue Jan 17 10:54:46 2012 Nobuyoshi Nakada <[email protected]>

* st.c (do_hash): it's the time to remove cast to unsigned int.

Tue Jan 17 07:30:12 2012 NARUSE, Yui <[email protected]>

* st.c (unpack_entries): Fix r34310: on unpacking, the position of
Expand Down
9 changes: 4 additions & 5 deletions st.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ static void rehash(st_table *);

#define EQUAL(table,x,y) ((x)==(y) || (*(table)->type->compare)((x),(y)) == 0)

/* remove cast to unsigned int in the future */
#define do_hash(key,table) (unsigned int)(st_index_t)(*(table)->type->hash)((key))
#define do_hash(key,table) (st_index_t)(*(table)->type->hash)((key))
#define do_hash_bin(key,table) (do_hash((key), (table))%(table)->num_bins)

/* preparation for possible allocation improvements */
Expand Down Expand Up @@ -462,9 +461,9 @@ unpack_entries(register st_table *table)
tmp_table.num_entries = 0;
memset(tmp_table.bins, 0, sizeof(struct st_table_entry *) * tmp_table.num_bins);
for (i = 0; i < table->num_entries; i++) {
st_index_t hash_val = do_hash(PKEY(table, i), &tmp_table);
add_direct(&tmp_table, PKEY(table, i), PVAL(table, i),
hash_val, hash_val % tmp_table.num_bins);
/* packed table should be numhash */
st_index_t key = PKEY(table, i), value = PVAL(table, i);
add_direct(&tmp_table, key, value, key, key % tmp_table.num_bins);
}
*table = tmp_table;
}
Expand Down

0 comments on commit 270ac46

Please sign in to comment.