Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bounding boxes with some zero length axes #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle bounding boxes with some zero length axes #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8df096
handle bounding box with some length zero axes
K-Meech Jun 22, 2024
c969a09
small formatting fixes
K-Meech Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 82 additions & 42 deletions src/main/java/ij3d/shapes/BoundingBox.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@

import java.awt.Font;
import java.text.DecimalFormat;
import java.util.Arrays;
import java.util.HashSet;
import java.util.List;
import java.util.Set;

import org.scijava.java3d.Appearance;
import org.scijava.java3d.BranchGroup;
Expand Down Expand Up @@ -72,6 +76,8 @@ public BoundingBox(final Point3f minp, final Point3f maxp, final Color3f color)
max.x += 0;
max.y += 0;
max.z += 0;

// points at the 8 corners of the 3D bounding box
final Point3f[] p = new Point3f[8];
p[0] = new Point3f(min.x, min.y, max.z);
p[1] = new Point3f(max.x, min.y, max.z);
Expand All @@ -88,18 +94,18 @@ public BoundingBox(final Point3f minp, final Point3f maxp, final Color3f color)
final float lx = max.x - min.x;
final float ly = max.y - min.y;
final float lz = max.z - min.z;
final float max = Math.max(lx, Math.max(ly, lz));
float min = Math.min(lx, Math.min(ly, lz));
if (min == 0 || max / min > 100) min = max;
final float lmax = Math.max(lx, Math.max(ly, lz));
float lmin = Math.min(lx, Math.min(ly, lz));
if (lmin == 0 || lmax / lmin > 100) lmin = lmax;
double tmp = 0.00001f;
while (min / tmp > 5)
while (lmin / tmp > 5)
tmp *= 10;

if (min / tmp < 2) tmp = tmp / 2;
if (lmin / tmp < 2) tmp = tmp / 2;

final float tickDistance = (float) tmp;

final float tickSize = max / 50;
final float tickSize = lmax / 50;

final Color3f c = color;
final float td = tickDistance;
Expand All @@ -109,20 +115,23 @@ public BoundingBox(final Point3f minp, final Point3f maxp, final Color3f color)
final float fy = tickDistance - (this.min.y % tickDistance);
final float fz = tickDistance - (this.min.z % tickDistance);

shape.addGeometry(makeLine(p[0], p[1], c, td, 0f, ts, true));
shape.addGeometry(makeLine(p[1], p[2], c, td, 0f, ts, true));
shape.addGeometry(makeLine(p[2], p[3], c, td, 0f, ts, true));
shape.addGeometry(makeLine(p[3], p[0], c, td, 0f, ts, true));
if (lx > 0) {
// All points that include min.x
List<Point3f> minXPoints = Arrays.asList(p[0], p[3], p[4], p[7]);
addLinesForAxis(shape, minXPoints, 0, c, td, fx, ts);
}

shape.addGeometry(makeLine(p[4], p[5], c, td, fx, ts, false));
shape.addGeometry(makeLine(p[5], p[6], c, td, 0f, ts, true));
shape.addGeometry(makeLine(p[6], p[7], c, td, 0f, ts, true));
shape.addGeometry(makeLine(p[4], p[7], c, td, fy, ts, false));
if (ly > 0) {
// All points that include min.y
List<Point3f> minYPoints = Arrays.asList(p[0], p[1], p[4], p[5]);
addLinesForAxis(shape, minYPoints, 1, c, td, fy, ts);
}

shape.addGeometry(makeLine(p[4], p[0], c, td, fz, ts, false));
shape.addGeometry(makeLine(p[1], p[5], c, td, 0f, ts, true));
shape.addGeometry(makeLine(p[2], p[6], c, td, 0f, ts, true));
shape.addGeometry(makeLine(p[3], p[7], c, td, 0f, ts, true));
if (lz > 0) {
// All points that include min.z
List<Point3f> minZPoints = Arrays.asList(p[4], p[5], p[6], p[7]);
addLinesForAxis(shape, minZPoints, 2, c, td, fz, ts);
}

shape.setAppearance(createAppearance(color));
addChild(shape);
Expand All @@ -131,34 +140,61 @@ public BoundingBox(final Point3f minp, final Point3f maxp, final Color3f color)
final DecimalFormat df = new DecimalFormat("#.##");

// x text
float v = this.min.x + fx;
Point3f pos =
new Point3f(v, this.min.y - 1.5f * tickSize, this.min.z - 1.5f * tickSize);
addText(df.format(v), pos, fontsize, color);
v = this.min.x + fx + tickDistance;
pos =
new Point3f(v, this.min.y - 1.5f * tickSize, this.min.z - 1.5f * tickSize);
addText(df.format(v), pos, fontsize, color);
if (lx > 0) {
float v = this.min.x + fx;
Point3f pos = new Point3f(v, this.min.y - 1.5f * tickSize, this.min.z - 1.5f * tickSize);
addText(df.format(v), pos, fontsize, color);
v = this.min.x + fx + tickDistance;
pos = new Point3f(v, this.min.y - 1.5f * tickSize, this.min.z - 1.5f * tickSize);
addText(df.format(v), pos, fontsize, color);
}

// y text
v = this.min.y + fy;
pos =
new Point3f(this.min.x - 1.5f * tickSize, v, this.min.z - 1.5f * tickSize);
addText(df.format(v), pos, fontsize, color);
v = this.min.y + fy + tickDistance;
pos =
new Point3f(this.min.x - 1.5f * tickSize, v, this.min.z - 1.5f * tickSize);
addText(df.format(v), pos, fontsize, color);
if (ly > 0) {
float v = this.min.y + fy;
Point3f pos = new Point3f(this.min.x - 1.5f * tickSize, v, this.min.z - 1.5f * tickSize);
addText(df.format(v), pos, fontsize, color);
v = this.min.y + fy + tickDistance;
pos = new Point3f(this.min.x - 1.5f * tickSize, v, this.min.z - 1.5f * tickSize);
addText(df.format(v), pos, fontsize, color);
}

// z text
v = this.min.z + fz;
pos =
new Point3f(this.min.x - 1.5f * tickSize, this.min.y - 1.5f * tickSize, v);
addText(df.format(v), pos, fontsize, color);
v = this.min.z + fz + tickDistance;
pos =
new Point3f(this.min.x - 1.5f * tickSize, this.min.y - 1.5f * tickSize, v);
addText(df.format(v), pos, fontsize, color);
if (lz > 0) {
float v = this.min.z + fz;
Point3f pos = new Point3f(this.min.x - 1.5f * tickSize, this.min.y - 1.5f * tickSize, v);
addText(df.format(v), pos, fontsize, color);
v = this.min.z + fz + tickDistance;
pos = new Point3f(this.min.x - 1.5f * tickSize, this.min.y - 1.5f * tickSize, v);
addText(df.format(v), pos, fontsize, color);
}
}

private void addLinesForAxis(Shape3D shape, List<Point3f> minPoints, int axis, Color3f c,
float td, float f, float ts) {

// Store points in a set (to eliminate any duplicates)
Set<Point3f> minPointsSet = new HashSet<>(minPoints);

// Draw a line from each minimum point aligned with the correct axis (0=x, 1=y, 2=z)
for (Point3f minPoint : minPointsSet) {

Point3f maxPoint = new Point3f(minPoint);
if (axis == 0) {
maxPoint.x = max.x;
} else if (axis == 1) {
maxPoint.y = max.y;
} else {
maxPoint.z = max.z;
}

// if drawing a line out of the bounding box minimum, include tick marks
if (minPoint.equals(min)) {
shape.addGeometry(makeLine(minPoint, maxPoint, c, td, f, ts, false));
} else {
shape.addGeometry(makeLine(minPoint, maxPoint, c, td, 0f, ts, true));
}
}
}

private void addText(final String s, final Point3f pos, final float fontsize,
Expand Down Expand Up @@ -201,6 +237,10 @@ private Geometry makeLine(final Point3f start, final Point3f end,
final float tickSize, final boolean noTicks)
{
final float lineLength = start.distance(end);
if (lineLength == 0) {
throw new IllegalArgumentException("Can't create a line of length zero");
}

final int nTicks =
(int) Math.floor((lineLength - first) / tickDistance) + 1;

Expand Down
Loading