FILE-6 - Add more available date ranges to the date range dropdown #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DiegoRBaquero this PR is ready for review |
|
@guanzo @joaosa @DiegoRBaquero this PR is ready for review |
DiegoRBaquero
approved these changes
Aug 30, 2023
AmeanAsad
reviewed
Nov 7, 2023
| startDate: Date; | ||
| endDate: Date; | ||
| } | null { | ||
| const customRangeMatch = /^(\d{4})-(\d{2})-(\d{2}) (\d{4})-(\d{2})-(\d{2})$/g.exec(dateString); |
There was a problem hiding this comment.
Can you add a comment explaining what this regex does exactly?
AmeanAsad
reviewed
Nov 7, 2023
| } | ||
| case FilterType.DateRange: { | ||
| if (periodRange.dateRange === undefined || periodRange.dateRange.startDate > periodRange.dateRange.endDate) { | ||
| throw new Error("Invalid date range"); |
There was a problem hiding this comment.
Great that you're adding all this error handling in the functions. However, not seeing those errors being handled on the front end when you call this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add more available date ranges to dropdown
Issue Reference
#14
Demo
https://www.loom.com/share/db7582115b7e4d09857ec97f7dcbcd94?sid=2dc1bf95-af5a-4576-82d2-214ed2b9a268