Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct error in buffer shim documentation #768

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

bcheidemann
Copy link
Contributor

@bcheidemann bcheidemann commented Mar 20, 2021

This PR corrects an error in the Buffer shim documentation. Using webpack.ProvidePlugin as previously documented would result in Buffer being globally defined as:
{ __esModule: true, default: ..., Buffer: ... }
The update to the documentation results in Buffer being resolved correctly by webpack.

@humphd
Copy link
Contributor

humphd commented Mar 20, 2021

I still think a test that uses webpack to do the build would be smart, since all of these shims are aimed at using it in that context, otherwise regressions are going to happen where we break those builds and expectations.

@humphd humphd merged commit f8c9732 into filerjs:master Mar 20, 2021
@bcheidemann
Copy link
Contributor Author

I still think a test that uses webpack to do the build would be smart, since all of these shims are aimed at using it in that context, otherwise regressions are going to happen where we break those builds and expectations.

Something like this? #770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants