Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile to allow for paths with spaces in them #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Piroshky
Copy link

When I tried to use the Makefile to download the wiki sources it ended up deleting the
directory it was called from, due to the Makefile not being able to handle paths with
spaces in them.

The fix is to wrap the variables that hold the path in quotes when they are being passed
as arguments to commands.

When I tried to use the Makefile to download the wiki sources it ended up deleting the
directory it was called from, due to the Makefile not being able to handle paths with
spaces in them.

The fix is to wrap the variables that hold the path in quotes when they are being passed
as arguments to commands.
@filiparag filiparag self-requested a review March 25, 2022 23:18
@filiparag filiparag added the enhancement Improvement of an existing feature label Mar 25, 2022
@filiparag
Copy link
Owner

Thanks for opening the pull request. I am sorry for not replying earlier.

I noticed that you simplified declaration of MKFILEABS variable to use MAKEFILE_LIST. Unfortunately, FreeBSD's make impelentation desn't support it, so I can't accept that change, as it would break compatibility. The rest of changes are good and can be merged to the upstream.

I revised spacing fixes you provided so it follows cat's 8 character tabs. Hope you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants