Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
amolnayak311 committed Dec 13, 2023
1 parent f5595f6 commit f6ac82f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -566,11 +566,11 @@ class MultiPartitionPlanner(partitionLocationProvider: PartitionLocationProvider
walkLogicalPlanTree(newLp, qContext, true).plans
} else {
if (queryConfig.supportRemoteRawExport) {
logger.warn("Remote raw export not supported")
} else {
logger.warn(
s"Remote raw export is supported and the $totalExpectedRawExport ms" +
s" is greater than the max allowed raw export duration of ${queryConfig.maxRemoteRawExportTimeRange}")
} else {
logger.warn("Remote raw export not supported")
}
Seq(EmptyResultExec(qContext, dataset.ref, inProcessPlanDispatcher))
}
Expand Down
6 changes: 1 addition & 5 deletions query/src/main/scala/filodb/query/exec/StitchRvsExec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@ object StitchRvsExec {
if (mins.isEmpty) {
minTime = t
mins += r
}

else if (t < minTime) {
} else if (t < minTime) {
mins.clear()
mins += r
minTime = t
Expand All @@ -66,7 +64,6 @@ object StitchRvsExec {
}
}
}
println(s"t: $minTime, mins.length ${mins.length}")
if (mins.isEmpty && tsIter.isEmpty) throw new IllegalStateException("next was called when no element")
if (minTime > tsIter.head) {
nanResult.timestamp = tsIter.next()
Expand All @@ -81,7 +78,6 @@ object StitchRvsExec {
// until we have a different indicator for "unable-to-calculate", use NaN when multiple values seen
val minRows = mins.map(it => if (it.hasNext) it.next() else nanResult) // move iterators forward
val minsWithoutNan = minRows.filter(!_.getDouble(1).isNaN)
println(s"multiple mins for time $minTime, values are ${minsWithoutNan.map(_.getDouble(1))}")
// The second condition checks if these values are equal within the tolerable limits and if yes, do not
// emit NaN.
// TODO: Make the second check and tolerance configurable?
Expand Down

0 comments on commit f6ac82f

Please sign in to comment.